Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BetterDiscord incompatible with Discord's new security measures (BD does not load) #96

Closed
5HT2 opened this issue Mar 2, 2021 · 24 comments · Fixed by #120
Closed

BetterDiscord incompatible with Discord's new security measures (BD does not load) #96

5HT2 opened this issue Mar 2, 2021 · 24 comments · Fixed by #120
Labels
enhancement:implemented Enhancement that has been implemented enhancement:update Implementation that should be updated

Comments

@5HT2
Copy link

5HT2 commented Mar 2, 2021

Unsure how to troubleshoot, sorry.

mika % betterdiscordctl status
Discord: /opt/discord-canary
Modules: /home/mika/.config/discordcanary/0.0.119/modules
Index modified: yes
Linked injector directory: /home/mika/.local/share/betterdiscordctl/bd/0
Linked injector repository: https://github.com/rauenzi/BetterDiscordApp
mika % betterdiscordctl reinstall -f canary
Killing Discord canary processes...
discord-canary killed (pid 397977)
DiscordCanary killed (pid 397978)
DiscordCanary killed (pid 397981)
DiscordCanary killed (pid 397982)
DiscordCanary killed (pid 397984)
DiscordCanary killed (pid 398012)
DiscordCanary killed (pid 398020)
DiscordCanary killed (pid 398058)
DiscordCanary killed (pid 398071)
DiscordCanary killed (pid 398156)
Reinstalled.
mika % betterdiscordctl status
Discord: /opt/discord-canary
Modules: /home/mika/.config/discordcanary/0.0.119/modules
Index modified: yes
Linked injector directory: /home/mika/.local/share/betterdiscordctl/bd/0
Linked injector repository: https://github.com/rauenzi/BetterDiscordApp
mika % betterdiscordctl status^C
mika % betterdiscordctl -v status
V: Using Discord at /opt/discord-canary
V: Found modules in /home/mika/.config/discordcanary/0.0.119/modules
Discord: /opt/discord-canary
Modules: /home/mika/.config/discordcanary/0.0.119/modules
Index modified: yes
Linked injector directory: /home/mika/.local/share/betterdiscordctl/bd/0
Linked injector repository: https://github.com/rauenzi/BetterDiscordApp
mika % betterdiscordctl install -f canary
ERROR: Already installed.
mika % discord-canary &
[1] 398206
mika % DiscordCanary 0.0.119
(node:398207) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

(DiscordCanary:398207): Gtk-WARNING **: 11:23:48.926: Failed to parse /home/mika/.config/gtk-3.0/settings.ini: Key file does not have group “Settings”
Starting app.
Starting updater.
[Modules] Modules initializing
[Modules] Distribution: remote
[Modules] Host updates: enabled
[Modules] Module updates: enabled
[Modules] Module install path: /home/mika/.config/discordcanary/0.0.119/modules
[Modules] Module installed file path: /home/mika/.config/discordcanary/0.0.119/modules/installed.json
[Modules] Module download path: /home/mika/.config/discordcanary/0.0.119/modules/pending
[Modules] No updates to install
[Modules] Checking for host updates.
[Modules] Host is up to date.
[Modules] Checking for module updates at https://discord.com/api/modules/canary/versions.json
[Modules] No module updates available.

image


If there's other information I can provide that would help I can provide that, not sure what do to from here.

@5HT2
Copy link
Author

5HT2 commented Mar 2, 2021

Works after uninstalling canary and installing stable. Would be willing to troubleshoot why canary won't work.

@ObserverOfTime
Copy link
Collaborator

BBD doesn't work on Canary anymore. See BetterDiscord/BetterDiscord#442 (comment).

@ObserverOfTime ObserverOfTime pinned this issue Mar 2, 2021
@ObserverOfTime ObserverOfTime added the upstream Problem with upstream (BetterDiscord) label Mar 2, 2021
@ObserverOfTime ObserverOfTime mentioned this issue Mar 24, 2021
Closed
@therealOri
Copy link

therealOri commented Mar 24, 2021

This doesn't help with any issues on stable.
No one uses canary except for a small minority.

This "issue" should not be pinned as it doesn't help at all.
My issue was an actual issue involving a new STABLE discord update 0.0.14, betterdiscord not launching (again), and no repair function to fix shit.

Why was mine closed and then this pinned immediately after with actually nothing to do with anything.
All this does for anyone is say "Doesn't work with canary anymore"...Like that is supposed to help ANYONE else.

@ObserverOfTime
At least pin something useful and can give us more information..

@SelfMadeSystem
Copy link

BetterDiscord/BetterDiscord#598 (comment) seemed to fix it for me.

@5HT2
Copy link
Author

5HT2 commented Mar 24, 2021

rauenzi/BetterDiscordApp#598 (comment) seemed to fix it for me.

That looks like it adds a lot of unnecessary code and has base64 encoded html inside and a bunch of other stuff for some reason?? I really wouldn't trust some random mediafire link

@ObserverOfTime
Copy link
Collaborator

@therealOri This issue was pinned 3 weeks ago. That was when the update that broke BD was introduced in canary. The same update landed in stable yesterday or today. Follow the link in my earlier comment for more info and stop expecting me to spoonfeed you.

@therealOri
Copy link

@ObserverOfTime
I don't expect to be spoonfed information.
and thanks for clarification on when it was pinned, It only showed up for me after my issue was closed.

I just expect to have at least a link that redirects me or anyone to the "duplicate" issue when you closed my main issue so I could look into it further myself. Instead of sifting through 80+ closed issues to find the not so duplicated "duplicate" issue.

It's not even that hard to do either, literally just copy the link and paste it with a reason for closing the issue.
Closed for being a duplicate: <link of OG issue here>.
that simple and saves everyone else time. AND they get an answer.

instead of "closed" and added some labels.

(i'd respond to you on my closed issue but that is not where you pinged me.)

@ObserverOfTime
Copy link
Collaborator

ObserverOfTime commented Mar 25, 2021

@therealOri I had to close half a dozen duplicates so I stopped responding after the first two.

It's not even that hard to read the pinned issues before submitting a new one.
It's that simple and saves everyone else, including myself, time.

@bb010g
Copy link
Owner

bb010g commented Apr 2, 2021

I'm going to reopen this until we either officially deprecate betterdiscordctl or make it compatible with the new installation method.

@bb010g bb010g reopened this Apr 2, 2021
@bb010g bb010g changed the title Injector not loading BetterDiscord incompatible with Discord's new CSP (BBD does not load) Apr 2, 2021
@ObserverOfTime ObserverOfTime added enhancement:update Implementation that should be updated and removed upstream Problem with upstream (BetterDiscord) labels Apr 2, 2021
@ObserverOfTime ObserverOfTime changed the title BetterDiscord incompatible with Discord's new CSP (BBD does not load) BetterDiscord incompatible with Discord's new electron (BBD does not load) Apr 2, 2021
@bb010g bb010g changed the title BetterDiscord incompatible with Discord's new electron (BBD does not load) BetterDiscord incompatible with Discord's new security measures (BD does not load) Apr 2, 2021
@bb010g
Copy link
Owner

bb010g commented Apr 2, 2021

Working with the new BetterDiscord installation is very doable.

@SelfMadeSystem
Copy link

That's good. I hope to get a good betterdiscord again!

@ObserverOfTime
Copy link
Collaborator

ObserverOfTime commented Apr 3, 2021

You can use the GUI installer in the meantime. It does not support flatpak and snap though.

@SuwakoMmh
Copy link

I'm going to reopen this until we either officially deprecate betterdiscordctl or make it compatible with the new installation method.

I Hope betterdiscordctl won't get deprecated, I honestly love the CLI tool, the AppImage is fat for not much and can't be scripted.
Thanks for betterdiscordctl !

@IvarWithoutBones
Copy link

I'd really love for betterdiscordctl not to get deprecated as well, having an easy and minimal CLI alternative to the GUI application would be great.

@HTMLDevelopment
Copy link

You can use the GUI installer in the meantime. It does not support flatpak and snap though.

Thank you so much.

@bb010g
Copy link
Owner

bb010g commented May 21, 2021

Sorry for all the delay. betterdiscordctl v2.0.0 is in final review, and should be released within the next couple days. Early tests of #120 from anyone running Snap or Flatpak would be appreciated.

@mkikets99
Copy link

mkikets99 commented May 22, 2021

No luck for me to install on Flatpak

Flatpak 1.10.2
Discord: Stable 85712 (10a9883)
Linux 64-Bit (Fedora v33)
image
image

[5 preload-host-spawn-strategy] Running: /app/bin/zypak-helper child - /app/discord/Discord --type=zygote
Discord 0.0.14
(node:5) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Gtk-Message: 01:52:51.950: Failed to load module "xapp-gtk3-module"
Starting app.
Starting updater.
[Modules] Modules initializing
[Modules] Distribution: remote
[Modules] Host updates: enabled
[Modules] Module updates: enabled
[Modules] Module install path: /home/mkikets/.var/app/com.discordapp.Discord/config/discord/0.0.14/modules
[Modules] Module installed file path: /home/mkikets/.var/app/com.discordapp.Discord/config/discord/0.0.14/modules/installed.json
[Modules] Module download path: /home/mkikets/.var/app/com.discordapp.Discord/config/discord/0.0.14/modules/pending
[Modules] No updates to install
[Modules] Checking for host updates.
[Modules] Host is up to date.
[Modules] Checking for module updates at https://discord.com/api/modules/stable/versions.json
[Modules] No module updates available.

And... Discord act like a browser app...

@bb010g
Copy link
Owner

bb010g commented May 23, 2021

@mkikets99 Did you use betterdiscordctl v2.0.0? (betterdiscordctl --version will tell you.)

Try running cd ~/Downloads, curl -LO "https://github.com/bb010g/betterdiscordctl/raw/beta/betterdiscordctl", and then chmod +x ./betterdiscordctl. ./betterdiscordctl --version (not betterdiscordctl --version; you want to use the version in your user's Downloads directory) should print betterdiscordctl 2.0.0. Try using ./betterdiscordctl with your Flatpak install.

If you still have problems, please provide the commands you ran (and their outputs) and the outputs of ./betterdiscordctl --version & ./betterdiscordctl status.

@mkikets99
Copy link

mkikets99 commented May 23, 2021

@mkikets99 Did you use betterdiscordctl v2.0.0? (betterdiscordctl --version will tell you.)

Try running cd ~/Downloads, curl -LO "https://github.com/bb010g/betterdiscordctl/raw/beta/betterdiscordctl", and then chmod +x ./betterdiscordctl. ./betterdiscordctl --version (not betterdiscordctl --version; you want to use the version in your user's Downloads directory) should print betterdiscordctl 2.0.0. Try using ./betterdiscordctl with your Flatpak install.

If you still have problems, please provide the commands you ran (and their outputs) and the outputs of ./betterdiscordctl --version & ./betterdiscordctl status.

Ok, so it is posible to install on standard version...
But... Did something changed in 2.0.0? I mean...

[mkikets@localhost ~]$ betterdiscordctl install --flatpak
ERROR: Unknown top-level option: --flatpak
Use `betterdiscordctl --help` for more information.
.......
[mkikets@localhost ~]$ betterdiscordctl install --d-install flatpak
ERROR: Unknown top-level option: --d-install
Use `betterdiscordctl --help` for more information.
.......
[mkikets@localhost ~]$ betterdiscordctl install -i flatpak
ERROR: Unknown top-level option: -i
Use `betterdiscordctl --help` for more information.

Did I missing something?

@bb010g
Copy link
Owner

bb010g commented May 23, 2021

@mkikets99 You need to use ./betterdiscordctl --flatpak install, as --flatpak is a top-level option. The first error should have said ERROR: Unknown |install| option: --flatpak, which I'll fix.

@mkikets99
Copy link

@mkikets99 You need to use ./betterdiscordctl --flatpak install, as --flatpak is a top-level option. The first error should have said ERROR: Unknown |install| option: --flatpak, which I'll fix.

Well seems like something isn't working...

[mkikets@localhost ~]$ betterdiscordctl --version
betterdiscordctl 2.0.0
[mkikets@localhost ~]$ betterdiscordctl --flatpak install
ERROR: Unknown top-level option: --flatpak
Use `betterdiscordctl --help` for more information.

@ObserverOfTime
Copy link
Collaborator

It's betterdiscordctl -i flatpak install now. Don't ask why.

@bb010g
Copy link
Owner

bb010g commented May 23, 2021

Oh yeah, sorry. Forgot we changed the syntax for that.

@bb010g
Copy link
Owner

bb010g commented May 23, 2021

betterdiscordctl v2.0.0 has been released! https://github.com/bb010g/betterdiscordctl/releases/v2.0.0 provides a changelog that goes over the CLI refresh. If you have problems with the new release, reporting them in new issues would be preferred so that everyone subscribed to this issue isn't notified.

@ObserverOfTime ObserverOfTime unpinned this issue May 25, 2021
@ObserverOfTime ObserverOfTime added the enhancement:implemented Enhancement that has been implemented label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:implemented Enhancement that has been implemented enhancement:update Implementation that should be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants