table: support check constraint in insert and update #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AilinKid
reviewed
Jun 9, 2020
table/tables/tables.go
Outdated
| t.tableID = tblInfo.ID | ||
| t.physicalTableID = physicalTableID | ||
| t.allocs = allocs | ||
| t.meta = tblInfo | ||
| t.Columns = cols | ||
| t.PublicConstraints = constraints |
There was a problem hiding this comment.
how about rename t.PublicConstraints to t.Constraints , which means the constraints in all state?
| } | ||
| writeableConstraint := make([]*table.Constraint, 0, len(t.PublicConstraints)) | ||
| for _, con := range t.PublicConstraints { | ||
| if con.State == model.StateDeleteOnly || con.State == model.StateDeleteReorganization { |
There was a problem hiding this comment.
constraint only has 3 state: None -> WriteOnly -> Public, but the code correctness here is ok.
| if shouldWriteBinlog(ctx) && !t.canSkipUpdateBinlog(col, value) { | ||
| binlogColIDs = append(binlogColIDs, col.ID) | ||
| binlogOldRow = append(binlogOldRow, oldData[col.Offset]) | ||
| binlogNewRow = append(binlogNewRow, value) | ||
| } | ||
| } | ||
|
|
||
| if len(t.WritableConstraint()) != 0 { | ||
| for _, constraint := range t.WritableConstraint() { | ||
| ok, isNull, err := constraint.ConstraintExpr.EvalInt(ctx, chunk.MutRowFromDatums(rowToCheck).ToRow()) |
There was a problem hiding this comment.
EvalBool has some problem, which sometimes can not return correct isNull
bb7133
pushed a commit
that referenced
this pull request
Oct 11, 2021
* mysql: Add NO_AUTO_CREATE_USER detection * mysql: Update Default SQL Mode * Include No_auto_create_user and only_full_group_by
CbcWestwolf
added a commit
to CbcWestwolf/tidb
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close pingcap#17425
What is changed and how it works?
ConstraintclassUpdateRecordandAddRecordCheck List
Tests
Code changes
Side effects
Related changes
Release note