WIP: Refactored producer to better use brod components #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarredOlson
reviewed
Sep 23, 2019
jeffgrunewald
approved these changes
Sep 23, 2019
|
Feels like you probably want to bump Elsa to at least 0.10.0 unless you're comfortable going to the big 1.0 with this one. |
ManApart
reviewed
Sep 25, 2019
Updating docs and fixing tests and then some
Change name to connection and now name is only used to name processes
jeffgrunewald
force-pushed
the
custom_registry
branch
from
ebb8f48
to
3cdf81c
Compare
added 2 commits
October 3, 2019 08:08
jeffgrunewald
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.