-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style/TrivialAccessor allows predicate methods by default #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just shoehorned a bugfix in here. |
Apart from the failing build - both changes should have changelog entries. |
alexdowad
force-pushed
the
allow_predicates
branch
3 times, most recently
from
February 22, 2016 09:59
8039d17
to
e799472
Compare
Apart from the missing changelog entry or two, everything looks good. Rebase and we're good to merge. |
This should cut down on the number of duplicate issues being raised on GitHub.
… are arg to method call
`Performance/Casecmp` would previously flag (and even autocorrect) uses of downcase/upcase which were not redundant.
…sistent indent This problem would only occur when the cop was configured as `ConsistentQuotesInMultiline: true`, and a heredoc had lines with differing indentation. Thanks to Arne de Herdt for the bug report.
…gexp metachars `Style/ConditionalAssignment` converted an assignment statement to a regex without escaping it, resulting in undesired behavior if any regexp metachar happened to appear anywhere in the assignment statement.
alexdowad
force-pushed
the
allow_predicates
branch
from
February 23, 2016 19:23
b6f5224
to
5a5eb89
Compare
Added missing changelog entry. Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should cut down on the number of duplicate issues being raised on GitHub.