Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/TrivialAccessor allows predicate methods by default #2867

Merged
merged 12 commits into from
Feb 23, 2016

Conversation

alexdowad
Copy link
Contributor

This should cut down on the number of duplicate issues being raised on GitHub.

@alexdowad
Copy link
Contributor Author

Just shoehorned a bugfix in here.

@bbatsov
Copy link
Collaborator

bbatsov commented Feb 21, 2016

Apart from the failing build - both changes should have changelog entries.

@alexdowad alexdowad force-pushed the allow_predicates branch 3 times, most recently from 8039d17 to e799472 Compare February 22, 2016 09:59
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 23, 2016

Apart from the missing changelog entry or two, everything looks good. Rebase and we're good to merge.

This should cut down on the number of duplicate issues being raised on GitHub.
`Performance/Casecmp` would previously flag (and even autocorrect) uses of
downcase/upcase which were not redundant.
…sistent indent

This problem would only occur when the cop was configured as
`ConsistentQuotesInMultiline: true`, and a heredoc had lines with differing
indentation.

Thanks to Arne de Herdt for the bug report.
…gexp metachars

`Style/ConditionalAssignment` converted an assignment statement to a regex
without escaping it, resulting in undesired behavior if any regexp metachar
happened to appear anywhere in the assignment statement.
@alexdowad
Copy link
Contributor Author

Added missing changelog entry. Rebased.

bbatsov added a commit that referenced this pull request Feb 23, 2016
@bbatsov bbatsov merged commit e18621c into rubocop:master Feb 23, 2016
@alexdowad alexdowad deleted the allow_predicates branch February 23, 2016 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants