Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for void defined? and self by Lint/Void cop #3871

Merged
merged 1 commit into from
Jan 7, 2017

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Jan 7, 2017

MRI checks void defined? and self expression.

See. https://github.com/ruby/ruby/blob/trunk/parse.y#L9571-L9654

However, Lint/Void cop does not check the expressions currently.

 # test.rb
def foo
  self
  defined? Foo
  nil
end
$ rubocop --cache false --only Lint/Void
Inspecting 1 file
.

1 file inspected, no offenses detected

This PR changes the cop to check the expressions.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

MRI checks void `defined?` and `self` expression.

See. https://github.com/ruby/ruby/blob/trunk/parse.y#L9571-L9654

However, `Lint/Void` cop does not check the expressions currently.

```ruby
 # test.rb
def foo
  self
  defined? Foo
  nil
end
```

```sh
$ rubocop --cache false --only Lint/Void
Inspecting 1 file
.

1 file inspected, no offenses detected
```

This PR changes the cop to check the expressions.
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 7, 2017

In theory we can check for all predicate methods in void context. If someone wrote a predicate with side effects - that predicate's not good anyways. :-)

@bbatsov bbatsov merged commit d72c80c into rubocop:master Jan 7, 2017
@pocke pocke deleted the self-and-defined-in-lint-void branch January 7, 2017 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants