Fix config#check to use loaded_path in warning #5278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a configuration refactor, the
#path
variable is no longeravailable in
config#check
, which causes rubocop to crash withNameError: undefined local variable or method path
if the deprecationcheck yields a deprecation warning.
This replaces the warning to use the instance variable
#loaded_path
and adds a spec to cover the behavior.
This is a small bug that looks to have been introduced with this commit and is impacting version 0.52.
Without the code change, the spec fails with:
This is also reproducible by defining the configuration:
which results in an exit with the
NameError
described above.Please let me know if I should add anything else to this PR! Thanks!
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
rake default
orrake parallel
. It executes all tests and RuboCop for itself, and generates the documentation.