Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach Performance/{Start, End}With cops to look for Regexp#match? #5744

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

bdewater
Copy link
Contributor

@bdewater bdewater commented Apr 2, 2018

As I found out for fastruby/fast-ruby#150 match? can be just as fast for small strings, but as the string size grows the performance gap widens.

  • Wrote good commit messages.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov bbatsov merged commit c35e94a into rubocop:master Apr 3, 2018
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 3, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants