Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative timestamps/offsets sometimes returned as positive in strings #33

Closed
j616 opened this issue May 14, 2018 · 1 comment
Closed

Negative timestamps/offsets sometimes returned as positive in strings #33

j616 opened this issue May 14, 2018 · 1 comment
Assignees
@j616
Labels
bug

Comments

@j616
Copy link
Contributor

j616 commented May 14, 2018

The various to string routines (inc to_sec_nsec and to_sec_frac) use self.sign * self.sec for returning the second component when self.sec is 0, this will always return 0. Any timestamp/timeoffset between -0:MAX_NANOSEC and -0:1 will return their absolute equivalent.
@j616 j616 added the bug label May 14, 2018
@j616 j616 self-assigned this May 15, 2018
@j616 j616 mentioned this issue May 15, 2018
Merged
@j616
Copy link
Contributor Author

j616 commented May 15, 2018

A related bug also affected creating timeoffsets from strings. Also fixed in the above PR.

@j616 j616 closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j616 j616

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@j616