Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Most read to WS articles pages (Test environment only) #10012

Closed
2 tasks
JonBeeb opened this issue Apr 5, 2022 · 1 comment · Fixed by #10049, #10079 or #10092
Closed
2 tasks

Add Most read to WS articles pages (Test environment only) #10012

JonBeeb opened this issue Apr 5, 2022 · 1 comment · Fixed by #10049, #10079 or #10092
Assignees
Labels
a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test most-read Tasks to create Most Read component optimo ws-london

Comments

@JonBeeb
Copy link
Contributor

JonBeeb commented Apr 5, 2022

Is your feature request related to a problem? Please describe.
Add most read to amp article pages
Most read can be seen on canonical pages
https://www.bbc.com/kyrgyz/articles/c72x8jgx17do
but is missing from the AMP version
https://www.bbc.com/kyrgyz/articles/c72x8jgx17do.amp

The configuration for most read in the Simorgh config
https://github.com/bbc/simorgh/tree/latest/src/app/lib/config/services

mostRead: {
      header: 'De one we dem de read well well',
      lastUpdated: 'De one we dem update for:',
      numberOfItems: 10,
      hasMostRead: true,
    },

Describe the solution you'd like
Add most read to the AMP article pages.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Fallback
Don't show component if data fails to load. Might need to show placeholder instead because of the responsive layout. Could use amp-bind to hide the title if data does not load

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Checklist

Additional context
Add any other context or screenshots about the feature request here.

@JonBeeb JonBeeb added the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Apr 5, 2022
@JonBeeb JonBeeb added this to the Most Read on AMP milestone Apr 5, 2022
@JonBeeb JonBeeb changed the title Add Most read to article pages Add Most read to WS article pages Apr 5, 2022
@JonBeeb JonBeeb changed the title Add Most read to WS article pages Add Most read to WS articles pages Apr 5, 2022
@MuhammadAHussain MuhammadAHussain changed the title Add Most read to WS articles pages Add Most read to WS articles pages (Test environment only) Apr 12, 2022
@MuhammadAHussain MuhammadAHussain added most-read Tasks to create Most Read component a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test optimo and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Apr 12, 2022
@MuhammadAHussain MuhammadAHussain self-assigned this Apr 12, 2022
@DarioR01 DarioR01 self-assigned this Apr 20, 2022
@MuhammadAHussain
Copy link
Contributor

MuhammadAHussain commented May 3, 2022

We would need to review numeral font size and space on both canonical and amp. Need to look at removing the margin above the title after psammead migration (mobile breakpoints).
Screenshot 2022-05-03 at 16 59 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test most-read Tasks to create Most Read component optimo ws-london
Projects
None yet
3 participants