Feature request: Ability to exclude files/directories from the archive

[fewstera]

Thanks for the great tool.

It would be great if it was possible to exclude files from being added to the source archive.

[robinjmurphy]

This sounds like a good feature. Is this something you'd be up for contributing? We can try and pick it up soon if not.

Should be easy to do as we already ignore some files https://github.com/bbc/speculate/blob/master/lib/archiver.js#L9-L11.

[fewstera]

We can pick this up. I'll submit a PR when I get time 👍

[lukejpreston]

I am having a look at doing this now

it currently uses regex var IGNORE_REGEX = /SOURCES|SPECS|RPMS|SRPMS|\.git/;

should it extend this in the package.json with a value like

"spec": {
  "exclude": ["pattern_1", "pattern_2"] OR "regex_pattern"
}

or did you guys have something else in mind?

[lukejpreston]

an alternative would be to specifiy what you wanted to package

"spec": {
  "entries": ["file1", "subdir/file2"]
}

and another option

read the package.json values for

• directories
• files
• main
• bin

only and also use the .npmignore file if one exists, along with the regex you have

which are all standard npm things people can use

also should that regex also include the build folder which is generated?

[jasonwilliams]

Lets not make it too magic, a simple excludes:[] is all we need for now.
Then we'll have to try and extend the IGNORE_REGEX or have something similar

[Mousius]

I think it'd be nicer to have package.json work as normally as possible, the spec section should really be for things we can't achieve easily with a normal package.json file.

Given that, I think we'd only have to implement directories and maybe files to start with as a generic "add these things to the RPM" for any of the given keys and see if there's anything further people want afterwards?

PRs always welcome 😸

[lukejpreston]

I am a fan of project config being put into the package.json, things like eslint, jest and webpack do this and it feels natural and nice

That said I haven't pursued it any further, the project I was working that was using this got canned and I don't have time to look into it

[Mousius]

This is now in 2.0.0-alpha.1 if anyone wants to try it out 😸