Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about differenciate errors #18

Closed
pablovilas opened this issue Dec 2, 2015 · 2 comments
Closed

How about differenciate errors #18

pablovilas opened this issue Dec 2, 2015 · 2 comments

Comments

@pablovilas
Copy link
Contributor

At the moment the event emitter fires a single 'error' type for message errors and queue conection errors. Would be great if those errors are separated in 'error' and 'message_error'. For example if you want to leave the message in the queue because you can't process it at the moment a message_error would be fired.
Also would be nice if a re-poll option is added when polling the queue fires an error.
I can do a pr for that If you are agree.
Thanks

@robinjmurphy
Copy link
Contributor

Hi @pablovilas. This is a duplicate of #16 so I'm going to close, but would be happy to welcome a PR for two separate error events.

error should be an AWS client error
processing_error should be an error returned to done for ease of logging

As for re-polling, we already start a new poll on error. If this behaviour isn't working for you, please raise a separate issue for it with an example.

@pablovilas
Copy link
Contributor Author

Sorry about duplication. I didn't see that there is no return keyword, so re-polling will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants