Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ApproximateReceiveCount is not part of QueueAttributeName #451

Closed
sosafe-anas-bakro opened this issue Jan 15, 2024 · 4 comments · Fixed by #452
Closed

[Bug]: ApproximateReceiveCount is not part of QueueAttributeName #451

sosafe-anas-bakro opened this issue Jan 15, 2024 · 4 comments · Fixed by #452

Comments

@sosafe-anas-bakro
Copy link

Describe the bug

Lint is complaining that ApproximateReceiveCount does not exist when setting attributeNames in Consumer.create as QueueAttributeName doesn't have it.

Previous versions it was a string so we didn't have issues, I guess someone forgot it.

Your minimal, reproducible example

Too small to create an example

Steps to reproduce

Try to fill out attributeNames in Consumer.create with [ApproximateReceiveCount] value, lint will complain __

Expected behavior

Lint shouldn't complain, the type QueueAttributeName should contain ApproximateReceiveCountshouldn't

How often does this bug happen?

None

Screenshots or Videos

No response

Platform

  • All

Package version

8.1.3

AWS SDK version

No response

Additional context

No response

@nicholasgriffintn
Copy link
Member

This takes the type from the AWS SDK, so they define what is correct here.

The comment here should probably be updated: https://github.com/bbc/sqs-consumer/blob/main/src/types.ts#L10

To change the example to simply link here: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-aws-sdk-client-sqs/Variable/QueueAttributeName/

But aside from that, this isn't a bug.

@sosafe-anas-bakro
Copy link
Author

Thanks @nicholasgriffintn, I added a comment here aws/aws-sdk-js-v3#5671, once fixed I guess the library needs to use the latest version of AWS SDK.

Copy link

🎉 This issue has been resolved in version 8.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants