Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide toolbox wrappers for some ICA algos #6

Closed
svendaehne opened this issue Mar 4, 2015 · 6 comments
Closed

Provide toolbox wrappers for some ICA algos #6

svendaehne opened this issue Mar 4, 2015 · 6 comments

Comments

@svendaehne
Copy link
Contributor

No description provided.

@svendaehne
Copy link
Contributor Author

For this issue (but also for the SSD/SPoC stuff) we need to decide how to include external functions, such as ICA implementations.

SPM and Fieldtrip ship the original code and simply provide wrappers to fit their toolbox conventions. I assume that would also be the way to go for us. But let's discuss it.

@BenjaminBlankertz
Copy link
Contributor

For including external function, we use so far the folder
bbci_private/import
as I feel it would not be appropriate to include code of other people into our git. However, this requires that external users take care of themselves to get the respective functions and to include them into their Matlab path.

@venthur
Copy link
Contributor

venthur commented Mar 5, 2015

Legally, we could include certain libraries in our toolbox if their license is compatible with ours. Unfortunately we don't have decided on a license yet (see #2).

Generally speaking, code licensed under non-copyleft licenses like MIT, BSD and even the LGPL (note the leading L), can always be included. Projects licensed under a copyleft license like GPL can only be included if our project is licensed under the GPL as well.

@svendaehne
Copy link
Contributor Author

Personally I would not have a problem with including code from others in our git. But I guess that is something we simply have to decide.

If we are going to include ICA code, then here are some options:
The fastICA code comes with GPL license and I found some SOBI (another ICA version) code that comes with BSD license. EEGLAB (and thus their ICA-Infomax implementation) comes with GPL as well.

So I guess Basti is right, we need to decide for a license for our toolbox first, before we can thing about what to include -- if we include. ;-)

@svendaehne
Copy link
Contributor Author

@svendaehne svendaehne changed the title Provide toolbox wrappers for PCA and some ICA algos Provide toolbox wrappers for some ICA algos Apr 22, 2015
@svendaehne
Copy link
Contributor Author

I separated the ICA wrapper issue from the PCA issue. PCA can be implemented by us. ICA has to be a wrapper for external code.

JohannesHoehne added a commit that referenced this issue Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants