Run bin/update-data to incorporate 2022 change requests #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbenno
reviewed
Mar 7, 2023
There was a problem hiding this comment.
Hey @sandbergja, thank you very much for the update and including a reference to the summarized outcomes of requested changes 2022.
During review, I noticed that there was one change (2022-007: type change from extinct to historical) missing in the updated data provided on https://iso639-3.sil.org.
I emailed the institute about it and would like to wait on their reply before merging the updates.
The change was missing in a earlier version of the web resource.
They resolved the issue and applied the update on their website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of changes here: https://iso639-3.sil.org/sites/iso639-3/files/reports/639-3_ChangeRequests_2022_Summary.pdf