Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add healthcheck #57

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Add healthcheck #57

merged 1 commit into from
Jan 16, 2021

Conversation

jokay
Copy link
Contributor

@jokay jokay commented Jan 16, 2021

Adds a healthcheck.

@bbernhard
Copy link
Owner

Just out of interest: Did you experience any problems with the service not being responsive? I mean it probably won't hurt to have a healthcheck in there, but in case you've experienced some actual issues I would prefer do add some debug logging to track the issue down. :)

@jokay
Copy link
Contributor Author

jokay commented Jan 16, 2021

This is not a question of responsiveness but of completeness 😉 no problems seen so far.

You will be able to see the state using docker ps or some monitoring systems.

CONTAINER ID        IMAGE                                    COMMAND                  CREATED             STATUS                    PORTS                                                              NAMES
3b93a07859d1        bbernhard/signal-cli-rest-api:latest     "/entrypoint.sh"         13 minutes ago      Up 13 minutes (healthy)   8080/tcp                    

e.g. Up 13 minutes (healthy).

@bbernhard
Copy link
Owner

This is not a question of responsiveness but of completeness wink no problems seen so far.

You will be able to see the state using docker ps or some monitoring systems.

CONTAINER ID        IMAGE                                    COMMAND                  CREATED             STATUS                    PORTS                                                              NAMES
3b93a07859d1        bbernhard/signal-cli-rest-api:latest     "/entrypoint.sh"         13 minutes ago      Up 13 minutes (healthy)   8080/tcp                    

e.g. Up 13 minutes (healthy).

Oh, didn't know that. Ok, then let's merge the change ;-). Thanks!

@bbernhard bbernhard merged commit 33f1016 into bbernhard:master Jan 16, 2021
@jokay
Copy link
Contributor Author

jokay commented Jan 16, 2021

I would even provide a /health endpoint for this use case which gets excluded for the logging, so it won't spam the logs.

@jokay jokay deleted the feature/add-health-check branch January 16, 2021 18:21
nomer pushed a commit to nomer/signal-cli-rest-api that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants