Fix Unicode and EOF positions #123
Conversation
…h#122 Signed-off-by: Denys Smirnov <denys@sourced.tech>
There was a problem hiding this comment.
Reviewed 1 of 204 files at r1.
Reviewable status: 1 of 205 files reviewed, 2 unresolved discussions (waiting on @bzz, @creachadair, and @dennwc)
driver/fixtures/fixtures_test.go, line 37 at r1 (raw file):
}, }, VerifyTokens: []positioner.VerifyToken{
👍 I wonder, what is the reason for us not to have this enabled for all the types?
fixtures/_integration.java.legacy, line 1 at r2 (raw file):
CompilationUnit {
Could somebody please remind, what is .legacy used for?
There was a problem hiding this comment.
Reviewed 1 of 204 files at r1.
Reviewable status: 2 of 205 files reviewed, 2 unresolved discussions (waiting on @bzz, @creachadair, and @dennwc)
There was a problem hiding this comment.
Reviewable status: 2 of 205 files reviewed, 2 unresolved discussions (waiting on @bzz and @creachadair)
driver/fixtures/fixtures_test.go, line 37 at r1 (raw file):
Previously, bzz (Alexander) wrote…
👍 I wonder, what is the reason for us not to have this enabled for all the types?
It only works for types with tokens.
fixtures/_integration.java.legacy, line 1 at r2 (raw file):
Previously, bzz (Alexander) wrote…
Could somebody please remind, what is
.legacyused for?
It's an integration test for the Parsing API v1. Soon we will have a chance to drop it.
There was a problem hiding this comment.
Reviewed 202 of 204 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @bzz)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
Enable conversion from UTF-16 code points to bytes. Fixes #122. Also fixes end-of-file positions.
To prevent regressions, enable token verification for string literals and simple identifiers.
Signed-off-by: Denys Smirnov denys@sourced.tech
This change is