Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set version for dependencies #9

Merged
merged 1 commit into from
Jul 13, 2017

Conversation

mcarmonaa
Copy link
Member

@mcarmonaa mcarmonaa commented Jul 13, 2017

  • versions are set to allow minor changes following semantic version, (in the end the specific versions are in glide.lock)
  • since bblfsh/sdk and srcd.works/go-errors.v0 don't have releases yet, their versions have been set to the current last commit

It passes the tests with this versions.

@mcarmonaa
Copy link
Member Author

mcarmonaa commented Jul 13, 2017

Since I can't assign reviewrs I mention to the maintainer: @abeaumont

@codecov
Copy link

codecov bot commented Jul 13, 2017

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #9   +/-   ##
======================================
  Coverage    84.5%   84.5%           
======================================
  Files           4       4           
  Lines         200     200           
======================================
  Hits          169     169           
  Misses         30      30           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09fd234...618bedb. Read the comment docs.

@mcarmonaa
Copy link
Member Author

Since I can't assign reviewers, I mention the maintainer: @abeaumont

@abeaumont abeaumont self-requested a review July 13, 2017 14:40
@abeaumont abeaumont self-assigned this Jul 13, 2017
@abeaumont abeaumont merged commit 2eeccc5 into bblfsh:master Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants