Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial bootstrap with create-react-app #1

Merged
merged 1 commit into from
Jun 20, 2017
Merged

initial bootstrap with create-react-app #1

merged 1 commit into from
Jun 20, 2017

Conversation

erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented Jun 20, 2017 •
edited
Loading

/cc @Serabe @dpordomingo (can't assign 😞)

@erizocosmico erizocosmico force-pushed the master branch 3 times, most recently from 4589d72 to e0dbb6a Compare June 20, 2017 11:01
@mcuadros mcuadros changed the title initial bootstrap with create-react-app initial bootstrap with create-react-app Jun 20, 2017
@mcuadros mcuadros changed the title initial bootstrap with create-react-app initial bootstrap with create-react-app Jun 20, 2017
@mcuadros mcuadros changed the title initial bootstrap with create-react-app initial bootstrap with create-react-app Jun 20, 2017
@mcuadros
Copy link
Contributor

include the DCO please

@erizocosmico erizocosmico force-pushed the master branch 2 times, most recently from 5b89761 to ef9f75c Compare June 20, 2017 12:27
@erizocosmico
Copy link
Contributor Author

Done @mcuadros

dpordomingo
dpordomingo approved these changes Jun 20, 2017
View reviewed changes
Copy link
Member

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erizocosmico
initial bootstrap with create-react-app
d2c0e39 
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico erizocosmico requested a review from Serabe June 20, 2017 13:00
@erizocosmico erizocosmico mentioned this pull request Jun 20, 2017
Merged
@Serabe Serabe merged commit 195c878 into bblfsh:master Jun 20, 2017
dpordomingo pushed a commit to dpordomingo/bblfsh-web that referenced this pull request Oct 4, 2017
@abeaumont
Merge pull request bblfsh#1 from dpordomingo/sdk1.1
b2bbdb2 
Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpordomingo dpordomingo dpordomingo approved these changes

@Serabe Serabe Awaiting requested review from Serabe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erizocosmico @mcuadros @dpordomingo @Serabe