add csscomb and editorconfig #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erizocosmico you said that this PR:
I did not found it. Did you missed it? Or did you meant to say that you already ran the linters and fixers for the whole project? |
|
No, I meant it has them. The hooks are not visible in the commit AFAIK, they are added to the |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
fix/editorconfig
branch
from
56e5ab7
to
61e57b4
Compare
|
Hooks are not committed at all. Ever. |
|
If you want, something like husky can be used for sharing hooks |
Serabe
approved these changes
Jun 29, 2017
|
Damn, thought the hooks were magically uploaded to the repo. Which, now that I think about it, makes no sense at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This already contains the hook from platform-starter.