Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add footer to the page #21

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Conversation

erizocosmico
Copy link
Contributor

No description provided.

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico erizocosmico requested a review from Serabe July 6, 2017 10:56
@Serabe
Copy link
Contributor

Serabe commented Jul 6, 2017

2017-07-06 at 16 48

@Serabe
Copy link
Contributor

Serabe commented Jul 6, 2017

For me is approved, but I would like to have @marnovo's approval before merging.

@erizocosmico
Copy link
Contributor Author

erizocosmico commented Jul 6, 2017 via email

@Serabe
Copy link
Contributor

Serabe commented Jul 6, 2017

@erizocosmico don't worry. I always do too.

@marnovo
Copy link

marnovo commented Jul 6, 2017

Yep, that's like it. 👍

As last moment feedback, would you guys change "coded by" to "built by" or any other word? How does it sound better? @Serabe @erizocosmico

@Serabe
Copy link
Contributor

Serabe commented Jul 6, 2017

Not for me. Though I would add some link to AST Explorer

@Serabe
Copy link
Contributor

Serabe commented Jul 6, 2017

In any case, my suggestion should be taken as a change of scope and be addressed on a different PR.

@marnovo
Copy link

marnovo commented Jul 6, 2017

@Serabe agreed. Approved, then (I can't formally approve in this org/repo…).

@Serabe Serabe merged commit 47537c0 into bblfsh:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants