add nodes to the index when they update as well #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, nodes were not being added once they were updated, for example, when the AST changed. This PR introduces changes to keep the UASTViewer working even when the AST changes. The good solution would be getting rid of the NodeIndex as it is right now and implement some more idiomatic way of handling that as the current approach is very flaky and requires some hacks to work properly, as can be seen in this PR. But we'll leave the refactor for another time. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
dpordomingo
approved these changes
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, nodes were not being added once they were
updated, for example, when the AST changed.
This PR introduces changes to keep the UASTViewer working even
when the AST changes.
The good solution would be getting rid of the NodeIndex as it is
right now and implement some more idiomatic way of handling that
as the current approach is very flaky and requires some hacks to
work properly, as can be seen in this PR.
But we'll leave the refactor for another time.