Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options to show locations and change server address #34

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

erizocosmico
Copy link
Contributor

@erizocosmico erizocosmico commented Jul 21, 2017

Closes #32
Closes #33

Adds the following options:

  • Show / hide locations
  • Use a custom server address

Also:

  • Modifies the Makefile so it generates a correct API URL value for prod.

screenshot_2017-07-21_11 05 05
screenshot_2017-07-21_11 05 12

Copy link
Member

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The showLocation feature works removing the location from the tree?

@erizocosmico
Copy link
Contributor Author

Nope, just conditionally renders the <Position> elements in the node. If we remove them from the tree there's no way to show them ever again 😱

@dpordomingo
Copy link
Member

dpordomingo commented Jul 21, 2017

Yes, I know... My point is: If you hide Locations, there is no way to bring back only one of them. I'd find it more useful if it'd work like a «collapse all» toogle, so you could uncollapse certain locations on demand without having to display all at once.

@erizocosmico
Copy link
Contributor Author

@dpordomingo but that was what it was asked...

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@Serabe Serabe merged commit 4a35ed3 into bblfsh:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants