Use eslint and prettier

[smacker]

It will allow to use consistent code style

[dpordomingo]

Great idea!!!
We (at Platform team) decided to standardize this things across our front projects through https://github.com/src-d/platform-starter
You could maybe take a look :D

[dpordomingo]

Is there no way to avoid this config here? Can not be moved any other place? 😢

[smacker]

there are 3 options how to save config: https://prettier.io/docs/en/configuration.html
I prefer in package.json. But if you like .rc file, I'll change it

[dpordomingo]

I don't like to have different solutions to the same problem, but if the consensus on platform-starter can not be followed here is bblfsh/dashboard because of a limitation of the tools used in this project, or due to its particularities, lets go ahead with this solution.

[dpordomingo]

@smacker you can merge once you had:

• separated the modifications in two commits:
  • first with the lint configurations and so,
  • the second one with all the modifications automatically made by the linter or required by it
• passed the @jbeardly requirement about the "Signed-off-by" more info, and here

[smacker]

@dpordomingo rebased. I don't have rights to merge. You need to press a button.

[bzz]

LGTM. and @dpordomingo same lack of merge rights here

[smacker]

Yeah! I have right to merge now.
I rebased commits with sign off, but CI still says they are missed. It's weird. But looks like all good now.
I'm merging.