-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard basic design #8
Conversation
0415a66
to
9983699
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small one, and ready to go
src/components/Header.js
Outdated
<label htmlFor='language'>Language:</label> | ||
<select | ||
id='language' | ||
<Label>Language</Label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you deleted the for
on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, my bad
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
9983699
to
f020311
Compare
Done @dpordomingo |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you can merge
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
f9254f8
to
0ea1b5e
Compare
Takes over #6. Just last commit.
Requires #5.
I did an amend by mistake in the previous PR and the history was fucked up, so I reworked it here.