Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard basic design #8

Merged
merged 3 commits into from
Jun 28, 2017
Merged

Conversation

erizocosmico
Copy link
Contributor

Takes over #6. Just last commit.

Requires #5.

I did an amend by mistake in the previous PR and the history was fucked up, so I reworked it here.

@erizocosmico erizocosmico changed the title Feature/design Dashboard basic design Jun 27, 2017
Copy link
Member

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small one, and ready to go

<label htmlFor='language'>Language:</label>
<select
id='language'
<Label>Language</Label>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you deleted the for on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, my bad

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico
Copy link
Contributor Author

Done @dpordomingo

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Copy link
Member

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can merge

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico erizocosmico merged commit 1be282d into bblfsh:master Jun 28, 2017
@erizocosmico erizocosmico deleted the feature/design branch June 28, 2017 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants