Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure with HTTPClient.get_content #130

Merged
merged 1 commit into from
Sep 6, 2011
Merged

Fix failure with HTTPClient.get_content #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/webmock/http_lib_adapters/httpclient_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def build_httpclient_response(webmock_response, stream = false, &block)
raise HTTPClient::TimeoutError if webmock_response.should_timeout
webmock_response.raise_error_if_any

block.call(nil, body) if block
block.call(response, body) if block

response
end
Expand Down
9 changes: 9 additions & 0 deletions spec/acceptance/httpclient/httpclient_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,15 @@
include_examples "with WebMock"
end

it "should work with get_content" do
stub_request(:get, 'www.example.com').to_return(:status => 200, :body => 'test', :headers => {})
str = ''
HTTPClient.get_content('www.example.com') do |content|
str << content
end
str.should == 'test'
end

context "Filters" do
class Filter
def filter_request(request)
Expand Down