Support http.rb 5.x #941
Merged
Support http.rb 5.x #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.0.0 had a breaking change. Fixes bblimke#940
|
This change looks clear and correct and is the 2nd version-dependent http.rb improvement done to this adapter. 🥳 http.rb CHANGELOG listing the breaking change: https://github.com/httprb/http/blob/master/CHANGES.md#500-2021-05-12 |
|
❤️ sweet! is it reasonable to wait for a new version that is released soon, or rather use the patched version for now? |
|
Thank you @horgh for the PR! @olleolleolle, @phoet thank you for reviewing and for the feedback. |
|
I just released version 3.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.0.0 had a breaking change.
Fixes #940
I'm not completely sure this is the right fix, but my tests work now with both 4.4.1 and 5.0.0 of
http.