export CFLAGS_ and CXXFLAGS_ when run cargo #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the changes in d6cdbf4 set up a `cflags_key` + `cxxflags_key` and values that would pass `--target=<triple><api-level>` to the compiler; these didn't actually get passed via `.env()` when building the command to run cargo. This means that the `cc` crate doesn't use the right api-level when compiling C/C++ code since it doesn't find the `CFLAGS_` and `CXXFLAGS_` that we intended to export. This recently caused an issue while testing the game-activity backend for android-activity on older versions of android because when targeting levels < 29 then any use of the `android_get_device_api_level` API needs to be inlined and that isn't currently happening - which leads to a runtime failure to lookup the symbol. Ref: rust-mobile/android-activity#88 (comment)
|
Published in v3.2.1 ✨ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the changes in d6cdbf4 set up a
cflags_key+cxxflags_keyand values that would pass--target=<triple><api-level>to the compiler; these didn't actually get passed via.env()when building the command to run cargo.This means that the
cccrate doesn't use the right api-level when compiling C/C++ code since it doesn't find theCFLAGS_andCXXFLAGS_that we intended to export.This recently caused an issue while testing the game-activity backend for android-activity on older versions of android because when targeting levels < 29 then any use of the
android_get_device_api_levelAPI needs to be inlined and that isn't currently happening - which leads to a runtime failure to lookup the symbol.Ref: rust-mobile/android-activity#88 (comment)