-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt official windows-rs API #5
Conversation
Very interesting. I was thinking about investigating this recently, so I'm very happy that you've done that for me haha. How does this impact build times? |
4.38s --> 7.66s Edit: May not be an accurate measurement. Best try it yourself. There's discussion about the speed (or lack thereof) compiling |
Yeah it's not a strict science, but ballparks are relevant. Will have a think on this for a bit and get back to you. 😄 |
@bbqsrc any update on this ? Would love to have this merged.... Since, The PR repo is deleted, Is there anyway I could least use this PR as a dependency ?? registry = { git = "https://github.com/bbqsrc/registry-rs", tag = "d912b165e826add5d484ff21683a044585cb591f" } is not working well EDIT: registry = { git = "https://github.com/bbqsrc/registry-rs", rev = "refs/pull/5/head" } is working good. Thanks to this. |
I just ran across this again, and wanted to close it because it seems stale. Just checking before I do, to make sure this change isn't wanted. |
@spikespaz it looks like everyone is slowly moving away from If the build times are still an issue on the latest version, and if these types aren't leaking into the public API, you may look into the recently released An up-to-date example is available at strawlab/iana-time-zone#117; let me know if you need assistance integrating/testing this for And landing this will be a "Fixes #9" 😬 |
It looks like the Can I fix that? |
I am wrong, that is not the case for libraries. |
@spikespaz I'm sure you've already heard this, but the official Rust guidance these days is: It depends on the project's needs, with the default being that the Cargo.lock is included. |
I do not know if this works. I am fairly new to Rust, but I did my best. I did this because I do not want both
winapi
andwindows-rs
as dependencies in my future project. Please see rust-windowing/winit#2057, as my contribution is based off of this.Please leave comments on any problems with the changes, and I will be sure to fix them. I do not know how you are testing this, I may wish to implement tests for you. 😄