Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add immediate flag to prop watchers #1159

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

bcakmakoglu
Copy link
Owner

🚀 What's changed?

  • Add immediate flag to prop watchers so we properly assign initial prop values to the store state
  • Remove waiting for d3zoom to be available before setting min/max zoom etc. as these values should be available when d3zoom is initialized making waiting redundant here and causing multiple calls of setState to queue the execution of this watcher

@bcakmakoglu bcakmakoglu added the bug Something isn't working label Nov 3, 2023
@bcakmakoglu bcakmakoglu self-assigned this Nov 3, 2023
Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: 6efc3cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-flow/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-flow-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 4:15pm
vue-flow-typedoc ✅ Ready (Inspect) Visit Preview Nov 3, 2023 4:15pm

@bcakmakoglu bcakmakoglu merged commit 8013c9c into release/1.24.2 Nov 3, 2023
5 checks passed
@bcakmakoglu bcakmakoglu deleted the fix/default-zoom branch November 3, 2023 16:22
This was referenced Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant