Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core,viewport): allow panning on scroll while selection is active #1250

Merged
merged 9 commits into from
Jan 21, 2024

Conversation

bcakmakoglu
Copy link
Owner

@bcakmakoglu bcakmakoglu commented Jan 21, 2024

🚀 What's changed?

  • Return false from currentKeyFilter if the keyFilter is a boolean value to not trigger the actual key handler and overwrite isPressed
  • Set isPressed to whatever keyFilter is if it's a boolean
  • Allow panning on scroll when selection is active

🐛 Fixes

@bcakmakoglu bcakmakoglu added the bug Something isn't working label Jan 21, 2024
@bcakmakoglu bcakmakoglu self-assigned this Jan 21, 2024
Copy link

changeset-bot bot commented Jan 21, 2024

🦋 Changeset detected

Latest commit: a82c675

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-flow/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-flow-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 0:40am
vue-flow-typedoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 0:40am

@bcakmakoglu bcakmakoglu marked this pull request as ready for review January 21, 2024 12:36
@bcakmakoglu bcakmakoglu changed the title chore(tooling,deps-dev): update antfu eslint conf fix(core,viewport): allow panning on scroll while selection is active Jan 21, 2024
@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc January 21, 2024 12:40 Inactive
@bcakmakoglu bcakmakoglu merged commit 4109cf1 into next-release Jan 21, 2024
5 checks passed
@bcakmakoglu bcakmakoglu deleted the fix/key-filter branch January 21, 2024 12:41
@github-actions github-actions bot mentioned this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant