Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core,key-press): check if key or code exists before matching #1257

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

bcakmakoglu
Copy link
Owner

🚀 What's changed?

  • Check if event.code or event.key are defined before trying to match keyfilter against keys

🐛 Fixes

@bcakmakoglu bcakmakoglu added the bug Something isn't working label Jan 25, 2024
@bcakmakoglu bcakmakoglu self-assigned this Jan 25, 2024
Copy link

changeset-bot bot commented Jan 25, 2024

🦋 Changeset detected

Latest commit: a079384

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-flow/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-flow-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 7:48am
vue-flow-typedoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 7:48am

@vercel vercel bot temporarily deployed to Preview – vue-flow-typedoc January 25, 2024 07:45 Inactive
@bcakmakoglu bcakmakoglu merged commit ac87e3d into next-release Jan 25, 2024
5 checks passed
@bcakmakoglu bcakmakoglu deleted the fix/key-press branch January 25, 2024 07:52
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant