Change config file to use toml like(=). Also remove viper because ya... #45
Conversation
| "source_dir": "/", | ||
| "gitlab_url": "gitlab.somwhere.com", | ||
| "gitlab_user": "gitlab_user", | ||
| } |
There was a problem hiding this comment.
Should we move this outside the test so that we can reuse?
There was a problem hiding this comment.
Idk. I think it will only really be used by this test. If other tests need it, then we can move it out then
| return ioutil.WriteFile(fileName, []byte(r), 0644) | ||
| } | ||
|
|
||
| func ReadTomlLike(fileName string) (map[string]string, error) { |
There was a problem hiding this comment.
Is this simply accessible to parser.go? Interesting
There was a problem hiding this comment.
any file can see anything declared in the same package including inside other files.
| func ReadTomlLike(fileName string) (map[string]string, error) { | ||
| m := make(map[string]string) | ||
| if _, err := os.Stat(fileName); err == nil { | ||
| r, err := regexp.Compile(`^([^\s#]+)\s*=\s*([^\s]+)$`) |
| func ReadTomlLike(fileName string) (map[string]string, error) { | ||
| m := make(map[string]string) | ||
| if _, err := os.Stat(fileName); err == nil { | ||
| r, err := regexp.Compile(`^([^\s#]+)\s*=\s*([^\s]+)$`) |
There was a problem hiding this comment.
regex to parse key=value.
|
|
||
| func ReadTomlLike(fileName string) (map[string]string, error) { | ||
| m := make(map[string]string) | ||
| if _, err := os.Stat(fileName); err == nil { |
There was a problem hiding this comment.
Does this describe just the structure or also return the contents? Can't we simply use read?
There was a problem hiding this comment.
I think this just checks if it exists.
|
Couple of questions.. Should add some comments but looks good otherwise |
new file format:
github_user = benjamincaldwell
source_dir = /Users/benjamincaldwell
@karanthukral