Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Shadow DOM compatibility #264

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

Bernton
Copy link
Contributor

@Bernton Bernton commented Oct 19, 2023

Change summary

Add :host to make library compatible with Shadow DOM. This was also done in tailwindcss recently:
tailwindlabs/tailwindcss#11200

Change type

  • No review
  • Small PR
  • Big PR
  • Refactor

Regarding:
https://github.com/bcc-code/bcc-platform/issues/122

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-coast-028fe6203-264.westeurope.3.azurestaticapps.net

Copy link
Collaborator

@laurensgroeneveld laurensgroeneveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks! I'll merge it and release a new beta version with this change.

@laurensgroeneveld laurensgroeneveld merged commit a362f4a into main Oct 19, 2023
7 checks passed
@laurensgroeneveld laurensgroeneveld deleted the feature/improve-shadow-dom-compatibility branch October 19, 2023 08:44
@Bernton
Copy link
Contributor Author

Bernton commented Oct 19, 2023

@laurensgroeneveld can you add it to the latest stable aswell? 1.8.1 or something like this? Since it's not a breaking change.

@laurensgroeneveld
Copy link
Collaborator

laurensgroeneveld commented Oct 19, 2023

Unfortunately we don't have a mechanic currently to update older releases... It should be fairly straightforward though to update to the 2.0 beta, especially if you don't extensively use the typography styles

@Bernton
Copy link
Contributor Author

Bernton commented Oct 19, 2023

@laurensgroeneveld this really should be established, what if you have a critical bug in 1.8.0, and you want to patch it without forcing everyone to switch to the v2 beta?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants