Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleans up the parallel random seeds in several places #210

Merged
merged 3 commits into from
Jul 13, 2016
Merged

Cleans up the parallel random seeds in several places #210

merged 3 commits into from
Jul 13, 2016

Conversation

nickhand
Copy link
Member

@nickhand nickhand commented Jul 13, 2016 •
edited
Loading

  • use the new function local_random_state from utils module
  • uses a global seed to generate new random seeds (any 32 bit integer) for all ranks
  • hopefully this is good enough to reduce any possible correlations between random numbers on different ranks
  • also fixes a bug in Subsample where the random seed wasn't being used

@nickhand nickhand changed the title Cleanups parallel random seeds in several places Cleans up the parallel random seeds in several places Jul 13, 2016
@nickhand nickhand merged commit 1b33359 into bccp:master Jul 13, 2016
@nickhand nickhand deleted the cleanup_random_seeds branch July 13, 2016 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nickhand