adding cylindrical grouping method algorithm #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the algorithm invariant with different number of ranks? The parallel algorithm looked a bit scary. Could you add a sentence or two in the docstring / comments about the key assumption that guarantees correct result ? |
|
It's not working quite yet but I think I know the issue |
* a lot more testing and this seems to work * takes advantage of some pandas magic for speed-ups
… and observer (0,0,0) cases
|
ok @rainwoodman I'll merge this if it looks good to you |
bug fix in scatter/gather
WIP: adding correlation function with Corrfunc
* a lot more testing and this seems to work * takes advantage of some pandas magic for speed-ups
… and observer (0,0,0) cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.