Interlaced species #428
Merged
Interlaced species #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It gives a bogus powerspectrum -- a few times larger.
This moves the FFT out of the main particle loop for the interlaced painter. It fixes the previous wrong result. But I don't see why...
|
This PR avoids memory reuse in interlaced handling, and also lifts the multiple FFTs outside of the loop. |
Sometimes we do push zero particles through the pipe due to fluctuations or weird cuts. The code shall not crash due to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the last cells of the pdf file:
mozilla.pdf
The mean is not properly normalized when interlacing is enabled. Looks like some of the buffer reuse is incorrect.