New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interlaced species #428

Merged
merged 4 commits into from Oct 23, 2017

Conversation

Projects
None yet
2 participants
@rainwoodman
Member

rainwoodman commented Oct 23, 2017

See the last cells of the pdf file:

mozilla.pdf

The mean is not properly normalized when interlacing is enabled. Looks like some of the buffer reuse is incorrect.

rainwoodman added some commits Oct 23, 2017

Add a test case that fails the cmean of the interlaced tomesh.
It gives a bogus powerspectrum -- a few times larger.
Deal with interlacing more efficiently.
This moves the FFT out of the main particle loop for the interlaced
painter.

It fixes the previous wrong result. But I don't see why...

@rainwoodman rainwoodman requested a review from nickhand Oct 23, 2017

@rainwoodman

This comment has been minimized.

Member

rainwoodman commented Oct 23, 2017

This PR avoids memory reuse in interlaced handling, and also lifts the multiple FFTs outside of the loop.

rainwoodman added some commits Oct 23, 2017

convert the error to a warning.
Sometimes we do push zero particles through the pipe due to
fluctuations or weird cuts. The code shall not crash due
to this.
@nickhand

this looks good to me!

@rainwoodman rainwoodman merged commit 9736b13 into bccp:master Oct 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 95.354%
Details

@rainwoodman rainwoodman deleted the rainwoodman:interlaced-species branch Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment