Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MeikyuKingdomBasic] 過去の変更で漏れた表2つを復元 #462

Merged

Conversation

h-mikisato
Copy link
Contributor

迷宮キングダム 基本ルールブックにて、過去のPR #218 で欠落した地名決定表(PNTx)、迷宮風景表(MLTx)を再度追記しました

旧版と表が変わっていないので、欠落前同様に派生元クラスに処理を委譲する設計としています。

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #462 (60863bf) into master (ff0cc55) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         289      290    +1     
  Lines       18760    18782   +22     
=======================================
+ Hits        17871    17892   +21     
- Misses        889      890    +1     
Impacted Files Coverage Δ
lib/bcdice/game_system/MeikyuKingdomBasic.rb 67.88% <ø> (ø)
lib/bcdice/game_system/BlindMythos.rb 99.41% <0.00%> (-0.59%) ⬇️
lib/bcdice/game_system.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/StellarKnights_Korean.rb 100.00% <0.00%> (ø)
lib/bcdice/game_system/Emoklore.rb 95.00% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0cc55...60863bf. Read the comment docs.

Copy link
Member

@ysakasin ysakasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@ysakasin ysakasin merged commit 8f9f157 into bcdice:master May 18, 2021
@h-mikisato h-mikisato deleted the fix/meikyukindombasic_lack_of_pnt_and_mlt branch November 27, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants