Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] テストデータYAML化 #79

Closed
wants to merge 5 commits into from
Closed

Conversation

esnya
Copy link
Member

@esnya esnya commented Aug 21, 2019

言語非依存の構造化ファイルにすることで、ポーティングライブラリや派生ツール作者に優しくなる可能性があります。

# GameType.yml
CaseName1:
  input: INPUT
  output: OUTPUT
  rands: [[1, 6], [2, 6]]

CaseName2:
  input: INPUT
  output: OUTPUT
  rands:
    - [1, 6]
    - [2, 6]
# ...

@esnya esnya force-pushed the test-yaml branch 2 times, most recently from fda0a30 to e2b7b1d Compare August 21, 2019 05:55
@codecov-io
Copy link

codecov-io commented Aug 21, 2019

Codecov Report

Merging #79 into master will decrease coverage by 0.16%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   85.74%   85.57%   -0.17%     
==========================================
  Files         176      175       -1     
  Lines       21163    20984     -179     
==========================================
- Hits        18146    17958     -188     
- Misses       3017     3026       +9
Impacted Files Coverage Δ
src/test/DiceBotTest.rb 69.47% <76.92%> (+0.65%) ⬆️
src/test/DiceBotTestData.rb 60% <0%> (-36%) ⬇️
src/diceBot/DiceBot.rb 94.29% <0%> (-0.32%) ⬇️
src/bcdiceCore.rb 71.66% <0%> (-0.22%) ⬇️
src/CardTrader.rb 15.61% <0%> (-0.04%) ⬇️
src/diceBot/Amadeus_Korean.rb 98.57% <0%> (ø) ⬆️
src/diceBot/Nuekagami.rb 95.65% <0%> (ø) ⬆️
src/diceBot/ColossalHunter.rb 98.16% <0%> (ø) ⬆️
src/diceBot/DarkDaysDrive.rb 95.16% <0%> (ø) ⬆️
src/diceBot/Dracurouge_Korean.rb 99.21% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc62b2...1feb4fa. Read the comment docs.

@esnya
Copy link
Member Author

esnya commented Aug 21, 2019

テストクリアしました。

@esnya esnya changed the title テストデータYAML化 [WIP] テストデータYAML化 Aug 21, 2019
@esnya
Copy link
Member Author

esnya commented Aug 22, 2019

rebaseしましたが、もうちょっと汎用的なアプローチを試しているところです。
https://github.com/esnya/BCDice/compare/master..dicebot-test-case-parser

@ochaochaocha3 ochaochaocha3 added the refactoring 内部構造の改良 label Oct 6, 2019
@ysakasin
Copy link
Member

TOML化を推進することになりましたので、このPRはクローズします

@ysakasin ysakasin closed this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 内部構造の改良
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants