Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DigestName should be EncryptionName? #83

Closed
ljiranek opened this issue Aug 3, 2017 · 1 comment
Closed

DigestName should be EncryptionName? #83

ljiranek opened this issue Aug 3, 2017 · 1 comment

Comments

@ljiranek
Copy link

ljiranek commented Aug 3, 2017 •
edited
Loading

In Cms.SignerInformation.cs line 348 DigestName is used to constuct the signature name. This should be the EncryptionName when the HASH algorithm is defined by EncryptionOid.

The fix was also done in Java BouncyCastle 2 years ago (9.5.2015) in DefaultCMSSignatureAlgorithmNameGenerator.java method getSignatureName

The source data (testing SOD) can be found in original issue created in Jira: http://www.bouncycastle.org/jira/browse/BMA-134
ljiranek added a commit to ljiranek/bc-csharp that referenced this issue Aug 3, 2017
@ljiranek
bcgit#83 DigestName changed to EncryptionName
7431ccf 
The verification of signer uses Encryption algorithm OID instead of Digest algorithm OID.
@ljiranek ljiranek mentioned this issue Aug 3, 2017
Open
@dghgit
Copy link
Contributor

dghgit commented May 30, 2021 •
edited
Loading

Thanks for the reminder, this is now fixed. The code will now try the enc OID first and then fall back to the digest OID.

@dghgit dghgit closed this as completed May 30, 2021
filipnavara pushed a commit to emclient/bc-csharp that referenced this issue Jun 23, 2021
@dghbc
github bcgit#83 - correct digest name fetch to check enc oid
db06bfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dghgit @ljiranek