-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tls injection mechanism #1517
base: main
Are you sure you want to change the base?
Tls injection mechanism #1517
Conversation
…nt) visible to TLS
… PQC provider. PQC algorithms now can be loaded without reflection (useful when compiling with GraalVM native-image).
Hi Sergejs, thanks for the PR. It will be a while before a full review can be done, but on a first pass I have seen some basic issues:
We are certainly interested in getting PQC algorithms into TLS, but our intention would be to proceed by publishing algorithms in the BC provider as usual, then having TLS add the registrar entries from the relevant standards and support them when it can find the algorithm via the provider. Perhaps you could comment a little about what you have in mind in terms of the basic "injection" idea here, particularly in comparison to the existing provider-based mechanism. |
…ng KEMs before others in InjectableKEMs.
…ving only Asn1Bridge and Asn1BridgeForInjectedSigAlgs there; no dependency on the tls package
…jection Mechanism. Besides, UniversalKeyPairGenerator is difficult to implement.
…fallback algorithm for the BC adapter (since <hash-name>WITHRSAANDMGF1 sometimes is not found)
I have developed a TLS injection mechanism. It can be used to inject PQC algorithms (KEMs and signature algorithms) into TLS 1.3. The injection mechanism is located in the org.bouncycastle.tls.injection package, where the InjectionPoint class has been defined. Then, there are many places where InjectionPoint is consulted for injected KEMs and signature algorithms, which are added to the corresponding lists of supported TLS algorithms.