[jp-0027] Test eligible employee numbers in PROD (fixed employee job data issues) #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Eligible employee numbers in challenge page and eligible ee report are:
Missing entries with Sept 1 eft dates
Missing entries with future layoffs
Includes entries for terminated/retired ees
Sept 5 -- Couple of issues:
a) for data conversion, the old employee job carried forward but no longer exists in BI interface data anymore. Those job record should be marked as 'Terminated'.
b) Per audit, the couple of business units were update on Sept 1 after the eligible employee snapshot took on 4:30am
c) some new or recent update job data doesn't pass to Greenfield until Sept 5, 2023. That why eligible doesn't has those records.
Changes
New staging table created for temporialy storing the BI job data for comparing purpose, use it for comparing whether the job data is exists or not, If no longer exists, mark it to 'terminated'.
Ticket