Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-15: Ltsa Land Review UI #1609

Merged
merged 26 commits into from
Aug 18, 2023
Merged

PIMS-15: Ltsa Land Review UI #1609

merged 26 commits into from
Aug 18, 2023

Conversation

BradyMitch
Copy link
Collaborator

@BradyMitch BradyMitch commented Jul 25, 2023

🎯 Summary

PIMS-15:

  • Parcel review UI changed to tabs menu.
  • Included tab for LTSA information.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@codeclimate
Copy link

codeclimate bot commented Jul 25, 2023

Code Climate has analyzed commit afa63dd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 56.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2%.

View more on Code Climate.

@dbarkowsky dbarkowsky marked this pull request as ready for review August 18, 2023 18:49
@dbarkowsky dbarkowsky self-assigned this Aug 18, 2023
@LawrenceLau2020
Copy link
Collaborator

New changes looks great!
When editing a parcel and then clicking save, I'm seeing this error:
TitleOwnership.tsx:22 Uncaught TypeError: Cannot read properties of undefined (reading 'then') at TitleOwnership.tsx:22:1

@dbarkowsky
Copy link
Collaborator

New changes looks great! When editing a parcel and then clicking save, I'm seeing this error: TitleOwnership.tsx:22 Uncaught TypeError: Cannot read properties of undefined (reading 'then') at TitleOwnership.tsx:22:1

LTSA info would come back as undefined when there was no data for that PID. Added condition that handles that in the LandForm component.

@dbarkowsky dbarkowsky merged commit 7288ee0 into bcgov:dev Aug 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants