Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-142 Update react-toastify #1644

Merged
merged 4 commits into from
Aug 29, 2023
Merged

PIMS-142 Update react-toastify #1644

merged 4 commits into from
Aug 29, 2023

Conversation

TaylorFries
Copy link
Collaborator

@TaylorFries TaylorFries commented Aug 10, 2023

🎯 Summary

PIMS-142:

Update react-toastify to 9.1.3

Had to adjust tests to keep them working.
In manual testing, the toastify notifications that pop up when axios is awaiting a request are working. I think they're just disappearing so quick when the request is successful that it doesn't find the text after, and the request is always immediately successful when axios is mocked in tests.

I added a mock reply that should keep it waiting instead of immediately fulfilling the promise.
Also removed some await options that wait for the promise to complete, because it doesn't need to in this case. We're only looking for the toastify notification before it completes.
~Dylan

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky removed the request for review from BradyMitch August 25, 2023 20:45
@github-actions github-actions bot added the Tests label Aug 28, 2023
@dbarkowsky dbarkowsky self-assigned this Aug 28, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 28, 2023

Code Climate has analyzed commit 5c2912c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.1%.

View more on Code Climate.

@TaylorFries
Copy link
Collaborator Author

changes approved

@dbarkowsky dbarkowsky merged commit 68aa7cf into dev Aug 29, 2023
2 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-142 branch August 29, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants