Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIMS-137] Update keycloak-js #1658

Merged
merged 1 commit into from
Aug 22, 2023
Merged

[PIMS-137] Update keycloak-js #1658

merged 1 commit into from
Aug 22, 2023

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-137: Update keycloak-js

No apparent issues with this module.

I did run into an issue where logging out sometimes failed. Some devs seem to have this issue, others don't.
This seems to be related to whether or not the user is on the VPN, which seems like an issue for a future fix.

Additionally, the logout doesn't redirect to the login page, but it seems like it probably should.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@codeclimate
Copy link

codeclimate bot commented Aug 22, 2023

Code Climate has analyzed commit 86ed942 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2%.

View more on Code Climate.

@dbarkowsky dbarkowsky merged commit b3fa13b into dev Aug 22, 2023
2 checks passed
@dbarkowsky dbarkowsky deleted the pims-137 branch August 22, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants