Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIMS-144] update styled-components #1664

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Aug 23, 2023

🎯 Summary

PIMS-144: update styled-components package
This required some import changes and specification of props typing.

To test this, I tried looking at components that would be affected and comparing their styles. I don't see any immediate differences that would indicate style failures.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@codeclimate
Copy link

codeclimate bot commented Aug 23, 2023

Code Climate has analyzed commit 6c0bd2b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2%.

View more on Code Climate.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update works locally and encountered no errors

@dbarkowsky dbarkowsky marked this pull request as ready for review August 24, 2023 15:40
@dbarkowsky dbarkowsky merged commit 165a9a6 into dev Aug 24, 2023
2 checks passed
@dbarkowsky dbarkowsky deleted the pims-144-update-styled-components branch August 24, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants