Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIMS-200] LTSA Parcel Popup #1685

Merged
merged 10 commits into from
Sep 6, 2023
Merged

[PIMS-200] LTSA Parcel Popup #1685

merged 10 commits into from
Sep 6, 2023

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Sep 1, 2023

🎯 Summary

PIMS-200: Create LTSA dialog to be accessed from parcel popup.

Testing Instructions:

  • Select a parcel from the parcel layer
  • Click LTSA Info to view popup

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky dbarkowsky self-assigned this Sep 1, 2023
@github-actions github-actions bot added the React label Sep 1, 2023
@codeclimate
Copy link

codeclimate bot commented Sep 1, 2023

Code Climate has analyzed commit 2af0131 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 77.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.4%.

View more on Code Climate.

@dbarkowsky
Copy link
Collaborator Author

I need to write some tests for this. Will take PR out of draft when that's done.

Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I am getting a bunch of console errors though:

image

@dbarkowsky
Copy link
Collaborator Author

dbarkowsky commented Sep 6, 2023

@LawrenceLau2020 I'm looking into that error.

Update: Should now be fixed. The DialogText component has a <p> tag internally. Removed the component.

@LawrenceLau2020
Copy link
Collaborator

@LawrenceLau2020 I'm looking into that error.

Update: Should now be fixed. The DialogText component has a <p> tag internally. Removed the component.

Look good, I'm not seeing any errors with the popup :)

@dbarkowsky dbarkowsky merged commit 3a6f143 into dev Sep 6, 2023
2 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-200-LTSA-Popup branch September 6, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants