Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-251: Prod Build Failing on SVG Imports #1714

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-251:

Moved the dependencies for vite from the Dockerfiles to the package.json.
I hope this will allow us to better track them when they update.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@codeclimate
Copy link

codeclimate bot commented Sep 20, 2023

Code Climate has analyzed commit 3240987 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8%.

View more on Code Climate.

@dbarkowsky dbarkowsky merged commit 254a4e1 into dev Sep 20, 2023
2 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-251-Prod-Build-Failing-on-SVG-Imports branch September 20, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants