Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-228 - Link to associated buildings from the Parcel's Review section taking you to map page #1792

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

Sharala-Perumal
Copy link
Collaborator

@Sharala-Perumal Sharala-Perumal commented Oct 5, 2023

🎯 Summary

PIMS-228: Link to associated buildings from the Parcel's Review section taking you to map page

Fixed the link to associated buildings on Parcel's review page.
Made the associated parcel on a building review page clickable and functional.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@Sharala-Perumal Sharala-Perumal self-assigned this Oct 5, 2023
@github-actions github-actions bot added the React label Oct 5, 2023
@github-actions github-actions bot added the Tests label Oct 6, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 6, 2023

Code Climate has analyzed commit 6f84bc7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 60.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8%.

View more on Code Climate.

@Sharala-Perumal Sharala-Perumal changed the title PIMS-228 - **DO NOT MERGE** PIMS-228 - Link to associated buildings from the Parcel's Review section taking you to map page Oct 6, 2023
Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selecting associated building from Parcel Details -> Review -> Associated Buildings now keeps user on same page instead of opening a new tab.
Approved.

@TaylorFries TaylorFries merged commit 1d8fc6f into dev Oct 6, 2023
6 checks passed
@TaylorFries TaylorFries deleted the PIMS-228 branch October 6, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants