Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIMS-325] Update bc-sans@2.1.0 #1836

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-325:

Updated bc-sans to version 2.1.0

Tested building container and navigating around site. No visible issues.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@dbarkowsky
Copy link
Collaborator Author

I am noticing a weird bug, but it seems to not be exclusively in this branch.
If you navigate to the Access Requests or Agencies page, then to the View Inventory page, the font will sometimes be a little bit smaller. Seems to already be in DEV, so not bc-sans-related.

@codeclimate
Copy link

codeclimate bot commented Oct 23, 2023

Code Climate has analyzed commit 7c99a7b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.9%.

View more on Code Climate.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds well no apparent issues or styling errors. Approved.

@dbarkowsky dbarkowsky merged commit 4cd8893 into dev Oct 24, 2023
6 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-325-update-bc-sans@2.1.0 branch October 24, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants