-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-245 Fix ESLint Errors #1919
Conversation
🚀 Deployment Information The APP Image has been built with the tag: |
Code Climate has analyzed commit 8a56995 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 55.4%. View more on Code Climate. |
🚀 Deployment Information The APP Image has been built with the tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No breaking changes, both formatting checks run with 0 warnings!
🚀 Deployment Information The APP Image has been built with the tag: |
🎯 Summary
PIMS-245
Changes
Fixed a handful of errors/warnings detected by ESLint.
Most of them were spacing issues.
Set to ignore the duplicate enum warning, as it seems like it's the values that are duplicated, not they keys, so I don't think we can remove them.
Testing
Some frontend commands:
npm run lint
should return no errors/warningsnpm run check
should return no errors/warningsSite should still navigate as normal after changes.
🔰 Checklist