Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-245 Fix ESLint Errors #1919

Merged
merged 4 commits into from
Nov 22, 2023
Merged

PIMS-245 Fix ESLint Errors #1919

merged 4 commits into from
Nov 22, 2023

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Nov 21, 2023

🎯 Summary

PIMS-245

Changes

Fixed a handful of errors/warnings detected by ESLint.

Most of them were spacing issues.

Set to ignore the duplicate enum warning, as it seems like it's the values that are duplicated, not they keys, so I don't think we can remove them.

Testing

Some frontend commands:

  • npm run lint should return no errors/warnings
  • npm run check should return no errors/warnings

Site should still navigate as normal after changes.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The APP Image has been built with the tag: 1919. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Nov 21, 2023

Code Climate has analyzed commit 8a56995 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.4%.

View more on Code Climate.

Copy link

🚀 Deployment Information

The APP Image has been built with the tag: 1919. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking changes, both formatting checks run with 0 warnings!

@dbarkowsky dbarkowsky merged commit 6ef53f4 into main Nov 22, 2023
3 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-245-Fix-ESLint-Errors branch November 22, 2023 17:08
Copy link

🚀 Deployment Information

The APP Image has been built with the tag: 1919. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants